Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup #134

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Warning cleanup #134

merged 2 commits into from
Nov 10, 2021

Conversation

DrPresident
Copy link
Collaborator

No description provided.

@DrPresident DrPresident changed the base branch from main to dev November 7, 2021 23:25
Copy link
Contributor

@FloppyDisck FloppyDisck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this!

@chris-ricketts
Copy link
Collaborator

Nice!

In order to squash the "warning: profiles for the non root package will be ignored, specify profiles at the workspace root:" warnings, you could remove this section from all the nested Cargo.toml files and add it underneath the [workspace] in the root Cargo.toml:

[profile.release]
opt-level = 3
debug = false
rpath = false
lto = true
debug-assertions = false
codegen-units = 1
panic = 'abort'
incremental = false
overflow-checks = true

All the workspace members will then use that profile for release. It would be good to restrict it to the wasm target but that's not possible yet: rust-lang/cargo#4897

@DrPresident DrPresident merged commit 47ee8b2 into dev Nov 10, 2021
@DrPresident DrPresident deleted the warning-cleanup branch November 10, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants