-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit source file types to Swift and headers #38
Conversation
This fixes a bug where the Info.plist file from this repo was included in the compile sources phase, which causes a build failure with the new Xcode 9 build system.
SeedStackViewController.podspec
Outdated
@@ -12,6 +12,6 @@ StackViewController is a Swift framework that simplifies the process of building | |||
s.author = { "Indragie Karunaratne" => "i@indragie.com" } | |||
s.source = { :git => "https://github.com/seedco/StackViewController.git", :tag => s.version.to_s } | |||
s.ios.deployment_target = '9.0' | |||
s.source_files = 'StackViewController/**' | |||
s.source_files = 'StackViewController/**/*.{h,swift}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mergesort thank you for the PR!
Did you mean to have source files set to StackViewController/*.{h,swift}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my mistake. Lemme tweak that.
Updated with the right file path. |
@vikmeup I just realized that I didn't bump the version number. Would it make sense to give it a version number of 0.3.1 in another patch? I don't have CocoaPods push access, so it would make sense to come from your side if you do choose to do that. Thanks! |
@mergesort I had problems running |
@mergesort done! version 0.3.1 successfully published. |
Thanks so much! |
This fixes a bug where the Info.plist file from this repo was included in the compile sources phase, which causes a build failure with the new Xcode 9 build system.