Support a lack of MANAGE_DOCUMENTS permission #551
Conversation
stevesoltys
changed the title
app/src/main/java/com/stevesoltys/seedvault/ui/storage/StorageRootResolver.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/stevesoltys/seedvault/ui/storage/StorageActivity.kt
Show resolved
Hide resolved
| summary = context.getString(R.string.storage_user_selected_location_summary), | ||
| availableBytes = null, | ||
| isUsb = false, // TODO: Check this if possible instead of forcing false | ||
| requiresNetwork = false, // TODO: Check this if possible instead of forcing false |
There was a problem hiding this comment.
I guess those are the downsides of using a fake root. We can't know how to set those flags.
There was a problem hiding this comment.
Hmm. I guess we could ask the user if the storage they selected is USB to fix this? Could open a ticket for this if you think it would work...
|
@stevesoltys maybe drop the |
|
Thanks for the updates @grote. Are all of the review comments resolved with your changes? Seems like they might be? Will update the initial commit as well. |
I think they should be. But please review them as well.
Thanks! |
When `android.permission.MANAGE_DOCUMENTS` is not granted, Seedvault prompts to select a storage location. Do not insist on resolving the storage's actual root, as it will likely (or perhaps always) fail. Use a fake storage root as is done for USB and app-based options. Known issues: * Selected location is assumed not to be USB and not to require network access in its storage options. Change-Id: I357b4c68673d71c087be41e9c94c2841c1d6658e
stevesoltys
force-pushed
the
bugfix/fix-no-manage-documents-permission
branch
from
8afee58
to
1e69831
Compare
Copy of #480, rebased on
android13.This PR is working based on my testing (we may need to address the PR comments in #480 still).