Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(start): Allow webpack dev server to be accessible via ip #129

Merged
merged 2 commits into from
Mar 13, 2018

Conversation

dborysiewicz
Copy link
Contributor

@dborysiewicz dborysiewicz commented Mar 13, 2018

Switching this allows it to be access via 127.0.0.1 still but also your machines ip address, this is useful for if you want to showcase or test (IE11 in a VM) your work on your local machine.

webpack/webpack-dev-server#147

Copy link
Member

@jahredhope jahredhope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any security concerns we need to raise around this?

@dborysiewicz
Copy link
Contributor Author

None I'm aware of 👍

@dborysiewicz dborysiewicz merged commit 40fb0eb into master Mar 13, 2018
@dborysiewicz dborysiewicz deleted the access-dev-via-ip branch March 13, 2018 23:19
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants