SASL Mechanism: AWS MSK IAM (making requested edits) #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #661
Indent json for godoc Co-authored-by: Achille <achille.roussel@gmail.com>
dominicbarnes
force-pushed
the
dominic/sasl-aws-msk-iam
branch
3 times, most recently
from
8d16f1e
to
aee4be0
Compare
cmaher
reviewed
Nov 23, 2021
sasl/aws_msk_iam/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/aws/aws-sdk-go v1.41.3 | ||
| github.com/segmentio/kafka-go v0.4.23 |
There was a problem hiding this comment.
I think this still needs to refer to a kafka-go version after the sasl changes have been merged? I also have no idea how the replace statement will work if this is imported somewhere else.
There was a problem hiding this comment.
Ah yeah, good catch. I'll remove that replace statement, then update the version here. I'm not 100% sure how we'll make sure they stay in sync, but we'll cross that bridge after merge.
|
changes look good to me! |
dominicbarnes
force-pushed
the
dominic/sasl-aws-msk-iam
branch
2 times, most recently
from
d0bc028
to
c71ca87
Compare
dominicbarnes
force-pushed
the
dominic/sasl-aws-msk-iam
branch
from
c71ca87
to
6bb6ae5
Compare
|
I think we're all clear now that I tagged v0.4.24 (which includes the SASL Metadata) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #763 and adds a commit which makes the changes I requested on the latest of that PR. My intention is to push this commit over to paxosglobal's fork, but I couldn't figure out how to open my PR to reflect that intent. As such, I'm opening the PR directly against main to see if my fixes bring everything into line.
This PR duplicates #763 (and will be merged in it's place)