Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint fixes #149

Merged
merged 5 commits into from
Jul 19, 2023
Merged

lint fixes #149

merged 5 commits into from
Jul 19, 2023

Conversation

extemporalgenome
Copy link
Contributor

@extemporalgenome extemporalgenome commented Jul 18, 2023 •
edited
Loading

The second commit (--fix) was machine processed, and so shouldn't need much review.

  • .golangci.yml: disable broken linter
  • golangci-lint run --fix
  • hand-fix some linting issues
  • just use errgroup instead of reinventing an errgroup

kevinburkesegment
kevinburkesegment reviewed Jul 18, 2023
View reviewed changes
context.go Outdated Show resolved Hide resolved
@extemporalgenome @kevinburkesegment
Update context.go
fd74c9f 
Co-authored-by: Kevin Burke <kevin.burke@segment.com>
@extemporalgenome extemporalgenome merged commit 91d974d into main Jul 19, 2023
4 checks passed
@extemporalgenome extemporalgenome deleted the lint-fixes branch July 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinburkesegment kevinburkesegment kevinburkesegment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extemporalgenome @kevinburkesegment