fix: update the x/exp package, and updated tagIsLess function #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tag.go
Outdated
| @@ -51,7 +51,15 @@ func SortTags(tags []Tag) []Tag { | |||
| return deduplicateTags(tags) | |||
| } | |||
|
|
|||
| func tagIsLess(a, b Tag) bool { return a.Name < b.Name } | |||
| func tagIsLess(a, b Tag) int { | |||
There was a problem hiding this comment.
I recommend you call this compareTags, since less implies a returned bool, which is no longer the case.
extemporalgenome
approved these changes
Sep 28, 2023
kevinburkesegment
pushed a commit
that referenced
this pull request
Sep 9, 2024
* fix: upgrade the x/exp package, and updated tagIsLess function * fix the test * tagIsLess -> tagCompare * revert dependency versions: attempt to fix subpackage failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slices.SortStableFunc now requires the cmp function to return an int, not bool.