tag: fix build #156
Merged
tag: fix build #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburkesegment
force-pushed
the
fix-build
branch
from
f06fbd2
to
414c42a
Compare
On tip (the Go 1.22 code freeze), Go reports that `compareTag` has the wrong method signature: ``` type func(a Tag, b Tag) int of tagCompare does not match inferred type func(a Tag, b Tag) bool for func(a E, b E) bool ``` Fix this by using the correct method signature.
kevinburkesegment
force-pushed
the
fix-build
branch
from
414c42a
to
9934686
Compare
|
turns out we needed to update the x/exp dependency, which has been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On tip (the Go 1.22 code freeze), Go reports that
compareTaghas the wrong method signature:Fix this by using the correct method signature.