datadog: fix race in test #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinburkesegment
force-pushed
the
race
branch
2 times, most recently
from
4c85781
to
09ee1ca
Compare
etiennep
approved these changes
Jun 20, 2024
While the metrics are set in the correct order, the use of a HTTP server to receive them means that the metrics can be received on the server side in any order, which fails the tests 1 time out of 200, potentially higher. This means we can't rely on any ordering on the server side in the test, and need to manually sort events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the metrics are set in the correct order, the use of a HTTP server to receive them means that the metrics can be received on the server side in any order, which fails the tests 1 time out of 200, potentially higher.
This means we can't rely on any ordering on the server side in the test, and need to manually sort events.