.github: ensure golangci-lint runs on PR's as well #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it just fails the main branch because it's not a requirement of a passing build.
kevinburkesegment
force-pushed
the
fix-lint
branch
8 times, most recently
from
98e47bc
to
bf43d9d
Compare
We turned on the linter to lint the "main" branch and any release branches, but we never actually fixed any of the issues reported by the linter. This is an attempt to do so. A lot of red herrings but some legitimate errors. Not strictly reported by the linter, but replace "syscall" uses with "x/sys/unix", as is recommended.
kevinburkesegment
force-pushed
the
fix-lint
branch
from
bf43d9d
to
59b8039
Compare
ABHINAV-SUREKA
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it just fails the main branch because it's not a requirement of a passing build.