Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: speed up local scripts #810

Merged
merged 5 commits into from
Jul 4, 2024
Merged

perf: speed up local scripts #810

merged 5 commits into from
Jul 4, 2024

Conversation

sripwoud
Copy link
Contributor

@sripwoud sripwoud commented Jun 28, 2024

  • Execute scripts concurrently where appropriated: build, test, lint, format scripts
    • either with yarn workspaces foreach --parallel option
    • or with concurrently
      in which case I still group the log outputs (to avoid having them interlaced) with the -g option

Ex of time execution reduction

Before After
yarn build:libraries 37.869s 24.732s
yarn test 22.553s 12.358s

Copy link

openzeppelin-code bot commented Jun 28, 2024

perf: speed up local scripts

Generated at commit: 2a98b0db3223722b66f33016cbee009f55e88cfe

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

package.json Outdated Show resolved Hide resolved
@sripwoud sripwoud mentioned this pull request Jun 28, 2024
9 tasks
package.json Show resolved Hide resolved
@sripwoud sripwoud changed the title chore: speed up local scripts perf: speed up local scripts Jun 28, 2024
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a comment.

package.json Outdated Show resolved Hide resolved
@cedoor
Copy link
Member

cedoor commented Jul 3, 2024

Ready to be merged I think @sripwoud! Thanks :)

@sripwoud sripwoud merged commit 1b046fd into main Jul 4, 2024
5 checks passed
@sripwoud sripwoud deleted the chore/yarn-parallel branch July 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops 🔧 Operations management and dev tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants