Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing implicit method from contract to interface #814

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

0xjei
Copy link
Contributor

@0xjei 0xjei commented Jul 1, 2024

Description

This PR adds the missing groupCounter() implicit method from Semaphore contract to ISemaphore contract interface. This will enable anyone to use this method just from the interface.

Related Issue(s)

none

Other information

this does not anything - gas costs included.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

Add missing implicit method from contract to interface

Generated at commit: e8c5f7aa816b67931cdcbfa9ca21a15d2130d475

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
15
19
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@cedoor cedoor merged commit e632099 into main Jul 1, 2024
5 checks passed
@cedoor cedoor deleted the chore/interface branch July 1, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants