Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing golint issues, added gitignore and boosted test coverage to 100% #22

Merged
merged 1 commit into from Oct 11, 2017

Conversation

tariq1890
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 10, 2017

CLA assistant check
All committers have signed the CLA.

@tariq1890
Copy link
Contributor Author

@thinkingserious Requesting your review on this :). Thanks

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 11, 2017
@mbernier
Copy link

Thank you @tariq1890 we will review this as soon as we're able!! Really appreciate it.

@thinkingserious thinkingserious merged commit 071a4d0 into sendgrid:master Oct 11, 2017
@thinkingserious
Copy link
Contributor

Hello @tariq1890,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@tariq1890
Copy link
Contributor Author

Thank you @mbernier @thinkingserious for being so active and responding to the issues & PRs.

This is the report card for smtpapi-go

https://goreportcard.com/report/github.com/sendgrid/smtpapi-go

We are at 100% :).

@thinkingserious
Copy link
Contributor

Thank YOU for your amazing support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants