Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Gometalinter in Travis CI build #52

Merged
merged 1 commit into from Oct 29, 2017

Conversation

vaskoz
Copy link
Contributor

@vaskoz vaskoz commented Oct 29, 2017

Fixes #50

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added the gometalinter to the TravisCI build
  • Enabled all linters with the exception of golint because golint is suggesting a change to an exported type which will break the public API.
  • Invoked gometalinter on ./....

At some point, the golint issues should also be fixed and the --disable=golint should be removed from .travis.yml

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 29, 2017
@thinkingserious thinkingserious merged commit a5ca89b into sendgrid:master Oct 29, 2017
@thinkingserious
Copy link
Contributor

Hello @vaskoz,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Megacheck to TravisCI build for smtpapi-go
2 participants