Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Added Code Review to Contributing.md #61

Merged
merged 2 commits into from Feb 19, 2020
Merged

docs: Added Code Review to Contributing.md #61

merged 2 commits into from Feb 19, 2020

Conversation

mptap
Copy link
Contributor

@mptap mptap commented Oct 31, 2017 •
edited

Fixes #59

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added Code Review to Contributing.md

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@mptap mptap mentioned this pull request Oct 31, 2017
Closed
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Mar 6, 2018
@thinkingserious thinkingserious changed the title Added Code Review to Contributing.md docs: Added Code Review to Contributing.md Feb 19, 2020
@thinkingserious thinkingserious merged commit bdeb5a3 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @mptap,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Code Review to Contributing.md
3 participants
@mptap @thinkingserious @mbernier