Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dynamic data support #63

Merged
merged 1 commit into from Feb 5, 2018
Merged

Adding dynamic data support #63

merged 1 commit into from Feb 5, 2018

Conversation

roncanada
Copy link
Contributor

@roncanada roncanada commented Feb 2, 2018 •
edited

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 2, 2018
@SendGridDX
Copy link

SendGridDX commented Feb 2, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

anfanycw
anfanycw approved these changes Feb 2, 2018
View reviewed changes
Copy link

@anfanycw anfanycw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkingserious thinkingserious merged commit 9e12f1e into master Feb 5, 2018
@thinkingserious
Copy link
Contributor

Hello @roncanada,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@childish-sambino childish-sambino deleted the dynamic_data_struct branch January 16, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfanycw anfanycw anfanycw approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roncanada @SendGridDX @thinkingserious @anfanycw