Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deploy job to test and deploy gh workflow #89

Merged

Conversation

Hunga1
Copy link
Contributor

@Hunga1 Hunga1 commented Feb 2, 2022

Added a deploy job to the test and deploy GitHub Action workflow that creates a new GitHub release when run for tags. Updated build status badge and Slack notification to cover deployments by the workflow.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Added a deploy job to the test and deploy workflow that creates a GitHub release. Updated slack notification message to handle deployment notifications. Updated build status badge.
.github/workflows/test-and-deploy.yml Outdated Show resolved Hide resolved
@JenniferMah
Copy link
Contributor

Workflow name need to be updated from test.yml to test-and-deploy.yml here

Updated test and deploy workflow filename reference
@Hunga1
Copy link
Contributor Author

Hunga1 commented Feb 3, 2022

Workflow name need to be updated from test.yml to test-and-deploy.yml here

Good catch! Updated the filename ref.

@childish-sambino childish-sambino merged commit 8ac1d57 into sendgrid:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants