Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add assets #18

Merged

Conversation

StevenRenaux
Copy link
Collaborator

Related to #7

Open WIP for discussion, to find a way to add an asset like the original asset feature.

With that function, the user must always give the path from the root.

<img src="{{ gotenberg_asset('public/img/logo.png') }}" alt="Logo"/>

src/Twig/GotenbergAssetExtension.php Show resolved Hide resolved
src/Builder/BuilderTrait.php Outdated Show resolved Hide resolved
src/Twig/GotenbergAssetExtension.php Outdated Show resolved Hide resolved
src/Twig/GotenbergAssetExtension.php Show resolved Hide resolved
src/Twig/GotenbergAssetExtension.php Outdated Show resolved Hide resolved
@StevenRenaux StevenRenaux force-pushed the features/Add-assets-automatically branch from 28c32ad to e2123f9 Compare February 22, 2024 16:16
…utomatically

# Conflicts:
#	config/services.php
#	src/Builder/BuilderTrait.php
#	src/Builder/MarkdownPdfBuilder.php
#	src/Builder/OfficePdfBuilder.php
#	src/Builder/TwigPdfBuilder.php
#	src/Builder/UrlPdfBuilder.php
src/Builder/AbstractPdfBuilder.php Outdated Show resolved Hide resolved
src/Pdf/Gotenberg.php Outdated Show resolved Hide resolved
src/Twig/GotenbergAssetExtension.php Outdated Show resolved Hide resolved
@StevenRenaux
Copy link
Collaborator Author

We will need to create a PR to fix multiple call to AssetBaseDirFormatter::resolve as we could find in the tests during mock.

@Neirda24 Neirda24 merged commit 9777047 into sensiolabs:main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants