Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot #37

Merged
merged 12 commits into from
May 24, 2024
Merged

Conversation

StevenRenaux
Copy link
Collaborator

@StevenRenaux StevenRenaux commented May 20, 2024

Add new form fields format, quality, omitBackground, optimizeForSpeed
POST /forms/chromium/screenshot/url
POST /forms/chromium/screenshot/html
POST /forms/chromium/screenshot/markdown

…v8-add-screenshot

# Conflicts:
#	src/DependencyInjection/SensiolabsGotenbergExtension.php
#	src/Pdf/GotenbergInterface.php
@StevenRenaux StevenRenaux changed the title [RELEASE-V8] Add screenshot [DRAFT][RELEASE-V8] Add screenshot May 20, 2024
@StevenRenaux StevenRenaux added this to the Publishing the package milestone May 20, 2024
@StevenRenaux StevenRenaux removed this from the Publishing the package milestone May 20, 2024
@Jean-Beru Jean-Beru added this to the v8.0.0 milestone May 23, 2024
Copy link
Contributor

@Neirda24 Neirda24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few things regarding the profiler, phpstan and phpunit. I did'nt review the whole thing yet. We still need to update the profiler to include screenshots and other APIs. Will not be included in this PR.

@Jean-Beru Jean-Beru changed the title [DRAFT][RELEASE-V8] Add screenshot Add screenshot May 23, 2024
@Neirda24 Neirda24 merged commit 886c49c into sensiolabs:main May 24, 2024
@Jean-Beru Jean-Beru deleted the release/v8-add-screenshot branch May 24, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants