[UPDATE] Better tests #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Neirda24
commented
May 30, 2024
Neirda24
commented
- Fix risky tests
- Add more tests
- Fix issue with int / float parsing with Units
Jean-Beru
reviewed
May 30, 2024
| @@ -535,8 +535,8 @@ private function addConfiguration(string $configurationName, mixed $value): void | |||
| 'single_page' => $this->singlePage($value), | |||
| 'pdf_format' => $this->pdfFormat(PdfFormat::from($value)), | |||
| 'pdf_universal_access' => $this->pdfUniversalAccess($value), | |||
| 'paper_width' => $this->paperWidth($value), | |||
| 'paper_height' => $this->paperHeight($value), | |||
| 'paper_width' => $splitAndParseStringWithUnit($value, $this->paperWidth(...)), | |||
There was a problem hiding this comment.
What about a Util/UnitParser with static methods. We could also test it.
There was a problem hiding this comment.
seems a bit much for just one usecase ? It is indirectly tested already.
There was a problem hiding this comment.
Are units used in with LibreOffice? If so, this util could be useful.
If not, let's keep it that way!
|
|
||
| protected function setUp(): void | ||
| { | ||
| self::$gotenbergClient = $this->createMock(GotenbergClientInterface::class); |
There was a problem hiding this comment.
Why is this variable static ?
There was a problem hiding this comment.
no reasons... habits I guess. Will change
| $builder->header('templates/invalid.html.twig'); | ||
| } | ||
|
|
||
| private function getChromiumPdfBuilder(false|null $twig = null): AbstractChromiumPdfBuilder |
There was a problem hiding this comment.
false|null $twig = null => bool $injectTwig = true ?
There was a problem hiding this comment.
yup. Don't know why I didn't went that way...
Neirda24
commented
May 30, 2024
Jean-Beru
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.