Add module versions to /version info #4593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
This commit adds module version info to the /version endpoint. Due to an
open Go bug, the commit is not testable yet. A unit test has been added
anyways, with a canary that should die when Go fixes the bug on their
end.
Why is this change necessary?
Closes #4590
Does your change need a Changelog entry?
Yes
Were there any complications while making this change?
While the change does work, as validated by starting up sensu-backend and querying the
/version
endpoint, it is not testable withgo test
yet, due to a Go bug. See golang/go#33976How did you verify this change?
Manually.
Is this change a patch?
No.