Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated script + fixing top nav #328

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antoineDuc
Copy link

Discussed w. @rmocnik

what’s the difference between “Visualization” and “EoB” on this page?
so it’s just Evalscript v1 vs v3?
Rok Mocnik
2:18 PM
yea but this doesn't exist anymore, should be removed

@antoineDuc antoineDuc changed the title Remove outdated scripts + fixing top nav Remove outdated script + fixing top nav Sep 13, 2024
@antoineDuc antoineDuc self-assigned this Sep 13, 2024
@jonasViehweger
Copy link
Contributor

jonasViehweger commented Sep 13, 2024

A few comments from my side:

  1. I agree that this script is outdated and should be replaced, however I wouldn't delete it but replace it with a script which does functionally the same (i.e. works outside of EOB to visualize NDVI)
  2. While we're at it we could also add a Raw script, to mirror everything we have for S2: https://custom-scripts.sentinel-hub.com/sentinel-2/ndvi/
  3. In general switching to the "official" Planetlabs NDVI colorramp would be good: https://marketing.pages.earth.planet.com/dataviz-tools/colormap-downloads
  4. I would avoid changing the permalink on single pages. All other planetscope scripts still have the planet_scope/script_name pattern. If we want to make that switch in the url, the cleanest way would be to remove the permalink from all, rename the README.mds to index.md and change the folder name from planet_scope to planetscope. This would enable jekyll to build the paths correctly.

So to answer the question in the PR: what’s the difference between “Visualization” and “EoB” on this page?: One works only on EOB while the other also works in SH Configurations which are used for WMS services.

@rmocnik rmocnik removed their request for review September 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants