Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store cluster.yaml in logs #251

Merged
merged 9 commits into from
Jun 27, 2023
Merged

Store cluster.yaml in logs #251

merged 9 commits into from
Jun 27, 2023

Conversation

zigaLuksic
Copy link
Collaborator

We decided for a simple procedure:

  1. eogrow-ray transfers cluster.yaml onto the head instance (similar to configs). This does not need to be named in a 'execution-specific-way' because if you switch to a different cluster configuration you'll (almost surely) also switch the head node
  2. Each pipeline checks if there is a cluster.yaml in the expected location, if there is, it copies it over.

Tested it out on a simple case to make sure it works

@zigaLuksic zigaLuksic requested a review from veseln June 26, 2023 14:07
@veseln
Copy link

veseln commented Jun 27, 2023

Just one question. Does this work if you spin a cluster, attach to it and then run a pipeline? Not a problem if it doesn't, just want to understand.

ray up cluster.yaml
ray attach cluster.yaml 
eogrow something

@zigaLuksic
Copy link
Collaborator Author

Just one question. Does this work if you spin a cluster, attach to it and then run a pipeline? Not a problem if it doesn't, just want to understand.

ray up cluster.yaml
ray attach cluster.yaml 
eogrow something

If you do a manual ray rsync_up cluster.yaml cluster.yaml "~/.synced_configs/cluster.yaml" then it will (or if you first run a pipeline with eogrow-raywhich copies it)

@veseln
Copy link

veseln commented Jun 27, 2023

Thanks, looks good.

@zigaLuksic zigaLuksic merged commit 3edc4a5 into develop Jun 27, 2023
7 checks passed
@zigaLuksic zigaLuksic deleted the store-cluster-data-in-logs branch June 27, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants