support for relative paths on sequelize.import #901
Conversation
|
Can you update the description to provide an example on how to use it? |
|
Nice work! :) Any chance we can get a test for a file that doesn't exist / errors? :) |
|
@ricardograca its pretty self explanatory O_o its relative paths for importing instead of having to define an absolute path |
|
I know that and you know that, but some future user reading this pull-request may not know that :) But, yes, it's probably obvious. The docs will need updating though. |
|
Thanks for the feedback! Updated the description with examples. |
|
docs are in a separate repo - https://github.com/sequelize/sequelize-doc |
| if (url.parse(path).pathname.indexOf('/') !== 0) { | ||
| // make path relative to the caller | ||
| var callerFilename = Utils.stack()[1].getFileName(); | ||
| path = url.resolve(callerFilename, path); |
There was a problem hiding this comment.
Wouldn't it be more proper to use path.resolve for this?
There was a problem hiding this comment.
Yes, sorry about that.
What variable name should "path" module be assigned to? Is "Path" ok?
|
cool :) |
|
tests aren't running for me |
Thanks for all the work on sequelize!
This patch makes this possible:
var Project = this.sequelize.import("assets/project")
or
var Project = this.sequelize.import("./assets/project")
where only
var Project = this.sequelize.import(__dirname + "/assets/project")
would work, previously (and still does).
I hope this contribution is usefull