Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move call to tri! out of check_recursion! #1159

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

purplesyringa
Copy link
Contributor

@purplesyringa purplesyringa commented Jul 26, 2024

As far as I can see, all uses of check_recursion! except this one don't early-return. The current code decreases remaining_depth but doesn't increase it back on visit failure. I don't have a test, but this is probably a bug.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 40dd7f5 into serde-rs:master Jul 26, 2024
13 checks passed
@purplesyringa purplesyringa deleted the fix-recursion branch July 26, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants