-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SauceLabs failing on PR's #31
Comments
Seems like it's a Travis security feature:
They suggest a workaround:
|
Doh! Now failing SauceLabs tests still pass the build. The goal is:
|
It's running SauceLabs on PR's when it shouldn't...
|
Testing CI stuff is hard… ;) Doing this as my own PR now so I can amend commits until it works as expected. I should’ve read the docs better: “The environment variable ${TRAVIS_PULL_REQUEST} is set to "false" when the build is for a normal branch commit. When the build is for a pull request, it will contain the pull request’s number.” Resources: http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when -testing-Pull-Requests Fixes #31
This happened when PR #29 triggered a build that failed. Seems to be user account related:
L838:
You used username 'None' and access key 'None' to authenticate, which are not valid Sauce Labs credentials.
The subsequent build by me worked, so I guess it's on PR's from other users accounts. Even though it's triggered by Travis which has credentials.
The text was updated successfully, but these errors were encountered: