Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file version match assembly version #38

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

mattpwhite
Copy link

Fixes #37

I just edited the csproj. It looks like this is what the Package panel in VS would do as well.

@nblumhardt
Copy link
Member

Thanks Matt! I think this is the best way forwards if we've regressed the version 👍

Unfortunately the other Serilog sinks get around this easily by having a static (usually 1.0) assembly version. We should nudge this package back in that direction in the long run, i.e. at its 2.0.

@nblumhardt nblumhardt merged commit c6d1f16 into serilog:dev Aug 8, 2018
@mattpwhite
Copy link
Author

Sure, whatever makes sense, I was just looking for a quick fix because this was breaking upgrades via msi for one of my apps. Any idea when this might be pushed to NuGet? If it will be a while, I’ll work around the issue, otherwise I’d just pick up the updated package.

And thanks for merging so quickly.

@nblumhardt
Copy link
Member

This changeset has been published as a -dev version; we'll push it through to master at some point, it'd be great if you can check that the dev version addresses the problem for you, some validation would help with getting this through the release process. Cheers!

@mattpwhite
Copy link
Author

This changeset has been published as a -dev version;

Good enough for me. I can confirm that this fixes the update issues for my installer. Thanks again.

@nblumhardt nblumhardt mentioned this pull request Jun 7, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants