Ensure we handle exceptions from the wrapped sink #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
approved these changes
Jun 7, 2019
| @@ -15,24 +15,24 @@ | |||
| <PublicSign Condition=" '$(OS)' != 'Windows_NT' ">true</PublicSign> | |||
| <PackageId>Serilog.Sinks.Async</PackageId> | |||
| <PackageTags>serilog;async</PackageTags> | |||
| <PackageIconUrl>http://serilog.net/images/serilog-sink-nuget.png</PackageIconUrl> | |||
| <PackageIconUrl>https://serilog.net/images/serilog-sink-nuget.png</PackageIconUrl> | |||
| <PackageProjectUrl>https://serilog.net</PackageProjectUrl> | |||
| <PackageLicenseUrl>http://www.apache.org/licenses/LICENSE-2.0</PackageLicenseUrl> | |||
There was a problem hiding this comment.
suggest <PackageLicense>Apache-2.0</PackageLicense>
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally,
_pipelinewas a logger, and therefore exceptions from the target sink were suppressed. After switching to invoke the wrapped sink directly, these escape and terminate the worker.I did my best to modernize the package where I could, on a drive-by. This means adding netstandard2.0 and net461 targets, as well as some dependency updates.
Should be pretty safe to get this out there :-)
Fixes #44