Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Serilog version dependency to support Unity and .netstandard 2.0+ #70

Merged
merged 1 commit into from
May 12, 2021
Merged

Conversation

bdovaz
Copy link

@bdovaz bdovaz commented May 7, 2021

@nblumhardt
Copy link
Member

Looks like this has stalled on some deprecated CSPROJ usage; the changes should be pretty straightforward (most sinks have now adopted <PackageLicenseExpression> etc.) in case you get to it before I do :-)

@bdovaz
Copy link
Author

bdovaz commented May 12, 2021

@nblumhardt Yes, please, if you don't mind changing it yourself because I don't have any experience with Nuget's publishing flow.

@Numpsy
Copy link
Member

Numpsy commented May 12, 2021

refs #71 :-)

@nblumhardt nblumhardt merged commit de3f270 into serilog:dev May 12, 2021
@bdovaz
Copy link
Author

bdovaz commented May 13, 2021

@nblumhardt Failed due to nuget's API key saying it is expired or invalid.

https://ci.appveyor.com/project/serilog/serilog-sinks-async

@nblumhardt
Copy link
Member

Should be fixed now, thanks 👍

@nblumhardt nblumhardt mentioned this pull request Jun 25, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants