Fix telemetry_sdk.version - should not include prerelease suffix
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r telemetry_sdk.version does not include commit hash
loomis
approved these changes
Jul 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We derive
telemetry_sdk.versionfromAssemblyInformationalVersion.On
main, this needs to be a plain, un-suffixed version, since the presence of a suffix indicates a prerelease package in SemVer.Today,
telemetry_sdk.versionis being reported from Serilog.Sinks.OpenTelemetry 1.0.0 as in:This PR drops version suffixing on
mainso that the value reported will be simply1.0.1, etc.