-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to bitflags 2 #667
Conversation
9191897
to
fe51d30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the rebase. It looks like this version contains some unrelated code, so I have just rebased the original PR and will merge there.
.downcast::<CFNumber>() | ||
.unwrap() | ||
.to_f64() | ||
.unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this code is unrelated?
It contains code to make the tests pass on macOS 14 (which includes my dev machine). That still seems useful? |
Yes, it could definitely be useful. Is it related to the bitflags changes though? Would you mind opening a new PR with these changes separating it out from the bitflags work? |
A rebased version of #549 (retaining authorship from the OP).
cc @mrobinson following up on your plan from #521 (comment).