Fixes #263: Ability to send arbitrary handles/file descriptors over ipc channel #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
|
|
|
Addresses Issue #263 |
|
I'm going to be honest - I don't have any idea when I'll get around to reviewing this massive PR for a feature that I don't need for my own uses of ipc-channel. Sorry. |
|
Ok. Let me know if there's anything that I can do to make the review easier ... I don't see a way to split it into several smaller PRs unfortunately. |
|
☔ The latest upstream changes (presumably #284) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can send arbitrary handles or file descriptors over an ipc channel by wrapping them into a
crate::platform::Descriptor. See thetest_transfer_descriptorfunction for details on how to do this.