-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a one-token cache #171
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3b1906b
Replace Box<str> with Rc<String> in CompactCowStr.
SimonSapin f4cfca9
Rename CompactCowStr to CowRcStr
SimonSapin 32733fb
Remove CowRcStr APIs that might allocate and used to never do so.
SimonSapin 8b7191b
Add `From<Cow<str>> for CowRcStr`
SimonSapin c661e7c
Rename compact_cow_str.rs to cow_rc_str.rs
SimonSapin 4aeca59
Remove unnecessary parenthesis
SimonSapin 49e8ab4
Rename private struct fields in ParserInput and Parser
SimonSapin b6072ca
Add a one-token cache.
SimonSapin 4705393
Token cache heuristic: monotonic position rather than token type.
SimonSapin a79e536
Make Parser::next return &Token instead of Token
SimonSapin c305bcf
Return &CowRcStr instead of CowRcStr in some Parser::expect_* methods
SimonSapin b806c39
Add expect_ident_cloned and expect_string_cloned
SimonSapin 336a12e
Remove CowRcStr::into_owned
SimonSapin a944f54
Fix Parser::seen_* in the presence of caching
SimonSapin 850eac1
Remove unnecesseray clone
SimonSapin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... This is kind of unfortunate, because it means that before we created a token, and now we need to create two copies of it... Does it happen too often? I wonder if that's why parsing a stylesheet becomes slower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parsing initially became slower when
Parser::next
would clone every single token in order to put in the cache. Returning&Token
removed these clones. In a minority of cases like here, the callers had to do these clones themselves instead. Note though thatToken::clone
never allocates. (Refcounting is used when a token contains an allocation.)I don’t know the reason for the more recent regression. I’ll investigate next week.