Add ParserState method to get current utf16 position #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
requested changes
Mar 26, 2024
|
In any case, |
This adds a `utf16_position` method on `ParserState`, exposing a `current_position` field that we compute. The implementation is closely following what what done to compute the utf16 column position.
nchevobbe
force-pushed
the
utf-16-position
branch
from
516e3f5
to
75ecffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
utf16_positionmethod onParserState, exposing acurrent_positionfield that we compute.The implementation is closely following what what done to compute the utf16 column position.
Note that this is my first contribution here and that I'm not very familiar with Rust.
Motivation: I'm currently building a css tokenizer for Firefox DevTools based on cssparser, replacing an existing JS-based implementation (https://bugzilla.mozilla.org/show_bug.cgi?id=1410184) so we can 1. use the same code than the CSS engine and 2. be faster. Consumers of those tokens are expecting utf16 start and end position for each tokens so the original can easily be manipulated in JS.