Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape backslash in special URL path components #469

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Escape backslash in special URL path components #469

merged 3 commits into from
Nov 6, 2018

Conversation

sfackler
Copy link
Contributor

@sfackler sfackler commented Nov 6, 2018 •
edited by larsbergstrom
Loading

Closes #468

This change is Reviewable

SimonSapin
SimonSapin reviewed Nov 6, 2018
View reviewed changes
src/parser.rs Outdated Show resolved Hide resolved
@SimonSapin
Copy link
Member

Thanks!

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 85af99e has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 85af99e with merge 1cc36c0...

bors-servo pushed a commit that referenced this pull request Nov 6, 2018
Auto merge of #469 - sfackler:backslash-path, r=SimonSapin
1cc36c0 
Escape backslash in special URL path components

Closes #468

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/469)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 1cc36c0 to master...

@bors-servo bors-servo merged commit 85af99e into servo:master Nov 6, 2018
@sfackler sfackler deleted the backslash-path branch November 6, 2018 18:51
@SimonSapin
Copy link
Member

https://crates.io/crates/url/1.7.2 is up. (I didn’t bother with the percent-encoding crate since it’s only docs changes.)

@sfackler
Copy link
Contributor Author

sfackler commented Nov 6, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSapin SimonSapin SimonSapin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfackler @SimonSapin @bors-servo