Validate Homu TOML file #420
Conversation
|
@aneeshusa I think I see what I've done wrong. I should be checking the generated TOML file at |
|
Correct! |
Crimack
force-pushed
the
407_valid_toml
branch
3 times, most recently
from
29d0563
to
7a77865
Compare
| config_path = os.path.join('/home', 'servo', 'homu', 'cfg.toml') | ||
| with open(config_path) as conf: | ||
| try: | ||
| toml.loads(conf.read()) |
There was a problem hiding this comment.
We can use toml.load instead which will handle opening and closing the file for us.
|
I think that's all your comments cleared up. Thank you for the feedback by the way, it was very easy to follow! The additions to |
| toml: | ||
| pip.installed: | ||
| - pkgs: | ||
| - toml == 0.9.1 # Ensure this is up to date with requirements.txt |
There was a problem hiding this comment.
Instead of a separate Salt state (block), add this to the pip.installed state above that installed Homu. Also, let's say 'in sync' instead of 'up to date'.
|
LGTM aside from that last comment, so go ahead and squash when you address that. |
|
All good now I think! |
|
Checked this locally in Vagrant and everything looks good. @bors-servo r+ |
|
📌 Commit 5e284fa has been approved by |
Validate Homu TOML file Draft of resolution to #407. `config_path` in sls/homu/toml.py is definitely wrong and should be corrected <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/420) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Draft of resolution to #407.
config_pathin sls/homu/toml.py is definitely wrong and should be correctedThis change is