Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrantfile - resiliently parse env variable #431

Closed
wants to merge 1 commit into from

Conversation

tallowen
Copy link

@tallowen tallowen commented Jul 6, 2016

env seems to be an array for me which means it cant have ".split" called on it. Here is an example:

SALT_NODE_ID=servo-master1
SALT_FROM_SCRATCH=true

Testplan:
vagrant up seems to work now

cc @aneeshusa do you mind reviewing this?


This change is Reviewable

@aneeshusa
Copy link
Contributor

@tallowen this is actually my fault (and the second time I've done this). There's already an open PR for this at #394 so I'm going to close this but please feel free to work on one of the other open issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants