-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Travis build status via GitHub instead of Travis hooks #454
Conversation
@bors-servo r+ |
📌 Commit da33177 has been approved by |
Has the status privilege been added to homu webhooks everywhere? |
What do you mean? The homu webhook in GitHub is one of the application ones Or did you mean somewhere other than GitHub? On Wed, Aug 10, 2016 at 10:29 AM, Manish Goregaokar <
|
The |
Aha, that one! It's not in the instructions ( On Wed, Aug 10, 2016 at 10:43 AM, Manish Goregaokar <
|
I think back when buildbot used to do this directly, we had added it. I don't think it was previously necessary for homu, but it's been a while since I looked. This is what my repo_add_homu.sh script does with the github api (tokens removed):
and
|
Yeah, I'd say about 1/6th of the repos had it set. I added it to the rest, unfortunately by hand before I saw that comment :-) |
@metajack That sounds like a useful script to put on the wiki or in this repo. |
Check Travis build status via GitHub instead of Travis hooks r? @Manishearth Fixes servo/servo#12739 cc: @metajack @edunham <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/454) <!-- Reviewable:end -->
☔ The latest upstream changes (presumably #425) made this pull request unmergeable. Please resolve the merge conflicts. |
I could have sworn I've given this script to everyone and it was documented somewhere. If that's not the case, where should I post it so people can find it easily in the future? |
I'd love to have an etc/ and doc/ folder in the saltfs repo containing scripts and docs and useful stuff. Not very fond of using the wiki for docs, since it's not so visible and has a different history. |
I don't think I have that script, but I agree with putting it in the repo (as opposed to having to give it to people). In #355 I am adding a scripts to a new I do think some docs would fit better in the repo (e.g. Vagrant usage instructions) with a pointer from the wiki. However, some things like a list of our EC2 machines or a link to seekrits should stay on the wiki IMO. Let's do |
I added my scripts to #457. |
Works. |
r? @Manishearth
Fixes servo/servo#12739
cc: @metajack @edunham
This change is