Update to Unicode 11.0 [breaking change]. #2
Conversation
|
☔ The latest upstream changes (presumably #3) made this pull request unmergeable. Please resolve the merge conflicts. |
This is a breaking change because the variants of the public `Script` enum have changed. Code that matches this enum exhaustively must be updated.
|
r? @pcwalton |
|
Script property is a Unicode Catalog type and expected to change on every single Unicode release. How about we mark the Enum as open now, so we don't have to call it breaking because of this again? |
|
11.0 is out now, so may as well skip straight to that? http://unicode.org/versions/Unicode11.0.0/ |
|
Agreed with @behnam. |
|
Updated to Unicode 11.0 and made the enum open. Note: The harfbuzz-sys crate hasn't yet been updated to a version of Harfbuzz that includes Unicode 11.0. Once it is, this can be updated to support the new HB_SCRIPT constants. |
mbrubeck
changed the title
|
☔ The latest upstream changes (presumably #4) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Version 12 available. |
This is a breaking change because the variants of the public
Scriptenum have changed. Code that matches this enum exhaustively must be updated.Depends on servo/rust-harfbuzz#78.