-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Turn On" when robot is idle #210
base: develop
Are you sure you want to change the base?
Conversation
hi, sorry for all comments below :) there are 16 places in code that relaying on off state that you changed in calculated state,
last thing, as result of that change there will be functions that will not get called, so they should be cleaned as well |
I did a bunch of manual testing, it worked as expected. A lot of the spots you highlighted are the tests themselves, or the actual state of the base station. |
if the mapping of actions (ACTION_ENTITY_TURN_ON, ACTION_ENTITY_TURN_OFF) in coordinator was removed, in case the vacuum doesn't support turn on/off, it will not support toggle, therefore mapping ACTION_ENTITY_TOGGLE should be removed with its function _vacuum_toggle. the problem that might get created and relevant not for ui but for the aws reporting status is CONSIDERED_POWER_STATE, not sure whether you tested it with logs in debug mode to see how things are working and whether all state changes are working - set as one mode, change to another, pause, resume, double resume, double pause, pickup when running, when idle. |
I didn't test everything, but I tested the main functions and everything seemed as expected. I left those functions in just in case something else is using them. Unfortunately I'm away on holiday for the next 4 weeks so feel free to reject this and work on it, but at least I found the cause of why turn on appears! |
Will try to get to it this weekend and take this branch and add the additional items i wrote |
The integration automatically sets the state of the vacuum to off when its not actively cleaning and it is unable to calculate another state.
When HA sees a state of off, it automatically adds a TURN ON button, instead of START CLEANING.
Changing the default state to idle addresses this.