take arbitrary IO for udp proxy

[ibigbug]

#1608

[zonyitoo]

Why was that necessary? SocketAddr is also implements ToSocketAddrs.

[ibigbug]

We need it to be SocketAddr when passing it to the underlying udp send

[zonyitoo]

Why was that necessary? SocketAddr is also implements ToSocketAddrs.

What was the key issue of the current master implementation that blocked you from passing SocketAddr to the APIs?

[ibigbug]

There is no issue passing a SocketAddr, but we can't and shouldn't pass IntoSocketAddrs into an abstract udp up, which is not always a tokio udpsocket

[ibigbug]

just realised it's a bit tricky to have the abstract io to be compatible with the raw socket operations. maybe I should separate two kinds of io and fail all the raw socket operation on the abstract one and give the control of that back to the author of which

[zonyitoo]

Please resolve all the CI failures.

[ibigbug]

Sure. There are still more to do. Will update soon.

[ibigbug]

@zonyitoo this should be ready for review now

[zonyitoo]

I was wondering another solution:

1. Make a trait DatagramTransport, which has APIs: send, recv, send_to, recv_from.
2. ProxySocket took a type impls DatagramTransport as the underlying I/O socket
3. UdpSocket impls DatagramTransport, which will require no lock or any other synchronization method in the application level.
4. You can impls your customized transport by impls DatagramTransport to support Sink and Stream.

[zonyitoo]

I could apply my ideas on your branch, if you allowed.

[ibigbug]

yeah of course, feel free to update

[zonyitoo]

@ibigbug Please set your branch to be "allow editable by maintainer".

[ibigbug]

@zonyitoo i odn't see that option, maybe it's from a forked repo?

[zonyitoo]

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

On user-owned forks, if you want to allow anyone with push access to the upstream repository to make changes to your pull request, select Allow edits from maintainers.

[ibigbug]

nothing shows up here?

[ibigbug]

https://github.com/orgs/community/discussions/5634

seems it doesn't work for org

[zonyitoo]

I may have to modify it on the master branch after merging this PR.