[Observability Homepage] Fix console error because of side effect (el…

…astic#75258)
shahzad31 · Aug 18, 2020 · 7fe263f · 7fe263f
1 parent 2d958e5
commit 7fe263f
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/x-pack/plugins/observability/public/pages/home/index.tsx b/x-pack/plugins/observability/public/pages/home/index.tsx
@@ -3,7 +3,7 @@
  * or more contributor license agreements. Licensed under the Elastic License;
  * you may not use this file except in compliance with the Elastic License.
  */
-import React from 'react';
+import React, { useEffect } from 'react';
 import { useHistory } from 'react-router-dom';
 import { fetchHasData } from '../../data_handler';
 import { useFetcher } from '../../hooks/use_fetcher';
@@ -15,12 +15,14 @@ export function HomePage() {
   const values = Object.values(data);
   const hasSomeData = values.length ? values.some((hasData) => hasData) : null;
 
-  if (hasSomeData === true) {
-    history.push({ pathname: '/overview' });
-  }
-  if (hasSomeData === false) {
-    history.push({ pathname: '/landing' });
-  }
+  useEffect(() => {
+    if (hasSomeData === true) {
+      history.push({ pathname: '/overview' });
+    }
+    if (hasSomeData === false) {
+      history.push({ pathname: '/landing' });
+    }
+  }, [hasSomeData, history]);
 
   return <></>;
 }