Remove sharedb-mingo-memory circular dependency #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyhwang
force-pushed
the
remove-mingo-dep
branch
from
bb317e2
to
7913314
Compare
nateps
approved these changes
Jul 25, 2018
|
Woohoo! This is majorly awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sharedb had depended on sharedb-mingo-memory for 4 tests, mostly relating to query subscriptions. This removes that dependency by faking out enough of MemoryDB in the tests to handle simple queries. (MemoryDB itself returns all documents in a collection given a query.)
I didn't want to put the simple query handling in MemoryDB, as that might lead people to think it may do more than it can. We don't want to re-implement all of Mingo, either.