Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce crossbeam channels #933

Closed
sharkdp opened this issue Jan 6, 2022 · 3 comments
Closed

Re-introduce crossbeam channels #933

sharkdp opened this issue Jan 6, 2022 · 3 comments

Comments

@sharkdp
Copy link
Owner

sharkdp commented Jan 6, 2022

After doing a proper performance evaluation, it would be benefitial to use crossbeam channels instead of the std mpsc channels, because:

  • there are some issues with the std channels version of recv_timeout() (Panic in Receiver::recv() rust-lang/rust#39364)
  • the current channels are not size-restricted and can lead to large memory usage
  • crossbeam channels are "supposed to be" faster.

See discussion in #895 and #916.

@tavianator
Copy link
Collaborator

Looks like Rust might do this for us :) rust-lang/rust#93563

@ijoseph
Copy link

ijoseph commented Jun 21, 2022

fwiw, removing the second -u

i.e. from

fd -uu  --glob -p  '**/src/kustomization.yaml'

to

fd -u  --glob -p  '**/src/kustomization.yaml'

was a valid workaround in my case

@tavianator
Copy link
Collaborator

@ijoseph Makes sense, but that won't work any more after #986. You'll have to do fd -I explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants