fix: display color when NO_COLOR is an empty string
#1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acuteenvy
force-pushed
the
fix-no-color
branch
from
85c0a76
to
6b028f6
Compare
acuteenvy
changed the title
NO_COLOR is an empty string
acuteenvy
force-pushed
the
fix-no-color
branch
from
6b028f6
to
4c74925
Compare
acuteenvy
force-pushed
the
fix-no-color
branch
from
4c74925
to
ad5fb44
Compare
tavianator
approved these changes
Nov 4, 2023
tavianator
added a commit
to tavianator/bfs
that referenced
this pull request
Nov 6, 2023
The docs say > Command-line software which adds ANSI color to its output by default > should check for a NO_COLOR environment variable that, when present > and not an empty string (regardless of its value), prevents the > addition of ANSI color. but we were not checking for the empty string. Link: https://no-color.org/ Link: sharkdp/fd#1421
|
Hmm I just realized after merging this that we should add a test. Do you feel like doing that @acuteenvy? |
|
I can't seem to get |
|
It would be possible to write a test, at least on linux. But it would require working with a pty, which would be fairly involved. |
|
Right yeah, I don't think it's worth the effort |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as sharkdp/bat#2767.