New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect error spans #474

Merged

wcampbell0x2a merged 1 commit into master from fix-read-all-span

Sep 4, 2024

Collaborator

wcampbell0x2a commented Sep 4, 2024

No description provided.


          Fix incorrect error spans

3914a41

github-actions bot commented Sep 4, 2024

Benchmark for `9a3f906`

Click to view benchmark

Test	Base	PR	%
count	3.4±0.02µs	3.6±0.01µs	+5.88%
deku_read_bits	1126.5±16.04ns	1113.1±24.44ns	-1.19%
deku_read_byte	3.6±0.11ns	3.4±0.05ns	-5.56%
deku_read_enum	3.5±0.02ns	3.1±0.03ns	-11.43%
deku_read_vec	31.7±0.32ns	31.7±0.46ns	0.00%
deku_write_bits	198.2±3.93ns	184.2±4.20ns	-7.06%
deku_write_byte	24.5±0.32ns	24.5±0.16ns	0.00%
deku_write_enum	22.7±0.64ns	22.8±0.81ns	+0.44%
deku_write_vec	410.5±4.42ns	437.1±6.54ns	+6.48%
read_all	3.8±0.05µs	5.5±0.04µs	+44.74%
read_all_bytes	5.6±0.04µs	3.8±0.06µs	-32.14%

sharksforarms approved these changes

View reviewed changes

wcampbell0x2a merged commit 81ea0ba into master

14 of 15 checks passed

wcampbell0x2a deleted the fix-read-all-span branch

September 4, 2024 16:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet