Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ImageNet-R, ImageNet-C, and other example tasks #85

Merged
merged 9 commits into from
Jul 17, 2022
Merged

Move ImageNet-R, ImageNet-C, and other example tasks #85

merged 9 commits into from
Jul 17, 2022

Conversation

kotekjedi
Copy link
Collaborator

@kotekjedi kotekjedi commented Jul 11, 2022 •
edited
Loading

  • examples/ -> tasks/
  • raccoons_OOD.py -> raccoons_ood.py

TODO:

[Examples moved]
dd5bba4 
* examples/ -> tasks/
* raccoons_OOD.py -> raccoons_ood.py
@kotekjedi
Copy link
Collaborator Author

I think that #75 should be merged first, and then we can update paths here as well.

@kotekjedi kotekjedi requested a review from stes July 11, 2022 11:37
stes
stes previously requested changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kotekjedi .

According to the contribution guide you can move the contents of imagenet_c.py directly into the __init__.py, or at least make sure in the __init__.py that the task is registered. (maybe the latter option is better)

shifthappens/tasks/imagenet_c/README.rst Outdated Show resolved Hide resolved
shifthappens/tasks/imagenet_r/imagenet_r.py Outdated Show resolved Hide resolved
shifthappens/tasks/raccoons_ood/README.rst Outdated Show resolved Hide resolved
shifthappens/tasks/raccoons_ood/README.rst Show resolved Hide resolved
@stes stes changed the title [Examples moved] Add ImageNet-R, ImageNet-C, and other example tasks Jul 11, 2022
@stes stes mentioned this pull request Jul 11, 2022
Closed
Alexander Panfilov added 2 commits July 11, 2022 22:28
[Examples moved]
dd3e43b 
* readme fixes
* md5 updated (lower case)
[flake8]
ab1286b 
* imports ignored
@zimmerrol
Copy link
Collaborator

@kotekjedi Once you have fixed the merge conflcits and fixed the hash, we can merge this PR.

Alexander Panfilov added 4 commits July 16, 2022 14:34
[Examples moved]
2583d97 
* examples/ -> tasks/
* raccoons_OOD.py -> raccoons_ood.py
[Examples moved]
5971cba 
* readme fixes
* md5 updated (lower case)
[flake8]
d066715 
* imports ignored
Merge remote-tracking branch 'origin/kotekjedi/moving_examples' into …
91c3ad2 
…kotekjedi/moving_examples
@github-actions
Copy link

Docstring Coverage Report

Name Total Miss Cover Cover%
examples/imagenet_c.py 20 0 20 100%
examples/imagenet_r.py 3 0 3 100%
examples/raccoons_OOD.py 3 0 3 100%
shifthappens/init.py 1 0 1 100%
shifthappens/benchmark.py 6 0 6 100%
shifthappens/model_comparison.py 5 0 5 100%
shifthappens/utils.py 4 0 4 100%
shifthappens/data/init.py 1 0 1 100%
shifthappens/data/base.py 7 0 7 100%
shifthappens/data/imagenet.py 6 0 6 100%
shifthappens/data/torch.py 4 0 4 100%
shifthappens/models/init.py 1 0 1 100%
shifthappens/models/base.py 7 0 7 100%
shifthappens/models/mixins.py 6 0 6 100%
shifthappens/models/torchvision.py 4 0 4 100%
shifthappens/task_data/init.py 1 0 1 100%
shifthappens/task_data/task_metadata.py 2 0 2 100%
shifthappens/task_data/task_registration.py 2 0 2 100%
shifthappens/tasks/init.py 1 0 1 100%
shifthappens/tasks/base.py 8 0 8 100%
shifthappens/tasks/metrics.py 2 0 2 100%
shifthappens/tasks/mixins.py 6 0 6 100%
shifthappens/tasks/task_result.py 2 0 2 100%
shifthappens/tasks/utils.py 3 0 3 100%
TOTAL 105 0 105 100.0%

RESULT: PASSED (minimum: 0.0%, actual: 100.0%)

@kotekjedi kotekjedi requested a review from zimmerrol July 16, 2022 12:42
@kotekjedi
Copy link
Collaborator Author

kotekjedi commented Jul 16, 2022 •
edited by zimmerrol
Loading

Done. I updated the hash (for me, it was an upper-case problem).

[Docs]
e8054fc 
* docs returned
@kotekjedi kotekjedi requested a review from stes July 16, 2022 19:22
@zimmerrol
Copy link
Collaborator

@kotekjedi Can you please update the READMEs for ImageNet-C/R based in the current docstring of the classes & modules (e.g., the references to the papers must be included).

[Docs]
309f94a 
* ImageNet-C/R description updated
zimmerrol
zimmerrol approved these changes Jul 17, 2022
View reviewed changes
Copy link
Collaborator

@zimmerrol zimmerrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimmerrol zimmerrol changed the title Add ImageNet-R, ImageNet-C, and other example tasks Move ImageNet-R, ImageNet-C, and other example tasks Jul 17, 2022
@zimmerrol zimmerrol merged commit 13e2c83 into main Jul 17, 2022
@zimmerrol zimmerrol deleted the kotekjedi/moving_examples branch July 17, 2022 09:26
kotekjedi added a commit that referenced this pull request Jul 17, 2022
@kotekjedi
Move ImageNet-R, ImageNet-C, and other example tasks (#85)
f600bd6 
* examples/ -> tasks/
* raccoons_OOD.py -> raccoons_ood.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimmerrol zimmerrol zimmerrol approved these changes

@stes stes Awaiting requested review from stes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[imagenet_r.py] wrong md5
3 participants
@kotekjedi @zimmerrol @stes