Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate workflow to test new approach in isolation #1039

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

shiftkey
Copy link
Owner

Trying to unblock the node20 dependency updates while packaging with an earlier version of glibc, by shifting the packaging steps into a containerized actions.

The three repositories that will now handle this setup:

@theofficialgman
Copy link

Trying to unblock the node20 dependency updates while packaging with an earlier version of glibc

What is blocked? nodejs/unofficial-builds builds linux-x64-glibc-217 for node20 as well.

@shiftkey
Copy link
Owner Author

What is blocked? nodejs/unofficial-builds builds linux-x64-glibc-217 for node20 as well.

I don't think I can swap in an a different flavour of node for these default Actions workflows"

Run actions/checkout@v4
/usr/bin/docker exec  0bbfc4e0c8493d6d277edd3a48d3581890b5fb4805a22dd1811cd36194d7f3b5 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)

As I understand this error, I think this points to a path in it's own container and installing something before isn't going to change this setup.

@theofficialgman
Copy link

What script/action are you running above? Can you post a link to the action log?

@shiftkey
Copy link
Owner Author

This is from https://github.com/shiftkey/desktop/actions/runs/9276025558/job/25522092914?pr=929#step:7:31 where we're upgrading action/checkout.

@theofficialgman
Copy link

right... in theory you could supply an equivalent node version (from nodejs/unofficial-builds) for those github actions and remove /__e/node20 as another option.

@shiftkey
Copy link
Owner Author

shiftkey commented Jun 2, 2024

right... in theory you could supply an equivalent node version (from nodejs/unofficial-builds) for those github actions and remove /__e/node20 as another option.

I've not seen this done before - what am I missing?

@shiftkey shiftkey force-pushed the prototype-better-dockerized-ci branch from 0db7fe1 to a2aa2bf Compare June 2, 2024 18:19
@shiftkey shiftkey force-pushed the linux branch 14 times, most recently from 0cc466d to 36a1f9e Compare June 2, 2024 20:28
shiftkey added a commit that referenced this pull request Aug 10, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 10, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 10, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 10, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
shiftkey added a commit that referenced this pull request Aug 11, 2024
* duplicate workflow to test new approach in isolation

* restore macOS builds where large runners are not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants