Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing MIME type to AppImage package #496

Merged
merged 4 commits into from
May 8, 2021
Merged

add missing MIME type to AppImage package #496

merged 4 commits into from
May 8, 2021

Conversation

Mrlinkwii
Copy link

@Mrlinkwii Mrlinkwii commented May 8, 2021

it should close #416 in terms of appimages

Description

-adds missing MIME type to the electron builder , x-scheme-handler/x-github-desktop-dev-auth which is mentioned in the red-hat builder and debian builder but not the electron builder

mimeType: [
'x-scheme-handler/x-github-client',
'x-scheme-handler/x-github-desktop-auth',
// workaround for handling OAuth flow until we figure out what we're doing
// with the development OAuth details
//
// see https://github.com/shiftkey/desktop/issues/72 for more details
'x-scheme-handler/x-github-desktop-dev-auth',

'x-scheme-handler/x-github-client',
'x-scheme-handler/x-github-desktop-auth',
// workaround for handling OAuth flow until we figure out what we're doing
// with the development OAuth details
//
// see https://github.com/shiftkey/desktop/issues/72 for more details
'x-scheme-handler/x-github-desktop-dev-auth',

what made me look at this was #416 (comment)

Screenshots

N/A

Release notes

Notes:no-notes

Copy link
Owner

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this @Mrlinkwii - I'd forgotten to check here when I applied this to the DEB and RPM installers at the time!

I'm going to merge this and cut a new release tomorrow so we can confirm this is resolved...

@shiftkey shiftkey changed the title add missing MIME type add missing MIME type to AppImage package May 8, 2021
@shiftkey shiftkey merged commit cd793ae into shiftkey:linux May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot redirect back to Desktop Client after signing into Github account on browser
2 participants