Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for GNOME console and newer GNOME editors #700

Merged
merged 6 commits into from
Apr 21, 2022

Conversation

Etaash-mathamsetty
Copy link

support gnome console as a terminal

Closes #699

@Etaash-mathamsetty
Copy link
Author

Etaash-mathamsetty commented Apr 18, 2022

so far detected in the options menu, but can't use it
edit: had to install konsole, switch it to konsole, then switch to gnome console and it worked fine, then uninstall konsole obviously
image

@shiftkey
Copy link
Owner

edit: had to install konsole, switch it to konsole, then switch to gnome console and it worked fine, then uninstall konsole obviously

I believe this is related to #344

@Etaash-mathamsetty
Copy link
Author

Etaash-mathamsetty commented Apr 18, 2022

edit: had to install konsole, switch it to konsole, then switch to gnome console and it worked fine, then uninstall konsole obviously

I believe this is related to #344

also could you merge this btw

@Etaash-mathamsetty
Copy link
Author

Etaash-mathamsetty commented Apr 18, 2022

to solve #344, this could work right?

//have to enable top level awaits
async function getDefaultShell(): Promise<Shell> {
  const shells = await getAvailableShells()
  if (shells.length > 0) {
    return shells[0].shell
  }
  return Shell.Gnome
}

export const Default = await getDefaultShell()

pardon me if the code is bad, I code in c++ lol
need to figure out how to enable top level awaits, since no other way I tried works
edit: I have no idea how to enable it

@shiftkey
Copy link
Owner

to solve #344, this could work right?

@Etaash-mathamsetty not sure, I'm very hazy on the issue and can't recall exactly what the root cause was. Let's kick that one down the road for now...

@shiftkey shiftkey changed the title Support gnome console add support for GNOME console and newer GNOME editors Apr 21, 2022
@shiftkey
Copy link
Owner

Thanks for the contribution @Etaash-mathamsetty!

@shiftkey shiftkey merged commit 3e39caf into shiftkey:linux Apr 21, 2022
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 21, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 25, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Apr 27, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request May 25, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 11, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 11, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 11, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 25, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 25, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jun 25, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Jul 6, 2022
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 10, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 11, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 12, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
shiftkey pushed a commit that referenced this pull request Aug 12, 2024
* add support for gnome console

* Delete configurationCache.log

* Update linux.ts

* fix cap of gnome

* support new GNOME Text Editor

* support GNOME builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Gnome console as a terminal
2 participants